Skip to content

Add SolidJS #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add SolidJS #9

wants to merge 7 commits into from

Conversation

@uiopak
Copy link

@uiopak uiopak commented Jun 3, 2022 •
edited
Loading

Pull request changes:

  • adds SolidJS
  • sets everywhere namespace to Company.WebApplication1 (replaced by user project name)
  • I had problem with project trying to generate new certificate, vite tried to read files before they ware created, fixed changing spawn to spawnSync
  • adds option to use pnpm instead of npm
  • adds option to generate project without https
  • resolves About http proxy error. #7
  • resolves Settings when publishing in production build. #8

stewartm83
stewartm83 approved these changes Jun 27, 2022
View reviewed changes
src/templates/Vite-CSharp/WeatherForecast.cs
@@ -1,4 +1,4 @@
namespace Vite_CSharp;
namespace Company.WebApplication1;
Copy link

@stewartm83 stewartm83 Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vite_CSharp is fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stewartm83 stewartm83 stewartm83 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Settings when publishing in production build. About http proxy error.

2 participants

@uiopak @stewartm83